Implement firmware update functionality by rytilahti · Pull Request #153 · rytilahti/python-miio

rytilahti · 2018-01-03T23:44:47Z

Add ability to perform firmware updates on the device.
Works either by passing an URL with md5sum for the firmware image,
or alternatively by passing a local filename.
In case of the input is a local filename, its md5sum will be calculated automatically,
and the update will be delivered by the built-in web server.

mirobo update_firmware http://10.10.10.150/v11_003094.pkg <md5sum>

or

mirobo update_firmware v11_003094.pkg

The install_sound functionality is also extended to use the builtin web-server class, so installing sound packages is as simple as calling mirobo install_sound <soundfile.pkg>.

For more details & archive of firmware updates see https://github.com/dgiese/dustcloud .

Thanks for exploring the device in-depth goes to the dustcloud project,
which also describes how to build own, custom firmwares.

houndci-bot · 2018-01-03T23:44:54Z

miio/vacuum_cli.py

+        click.echo("Using %s (md5: %s)" % (file, md5))
+    else:
+        pass
+        #Updater()


block comment should start with '# '

houndci-bot · 2018-01-03T23:44:54Z

miio/updater.py

+
+if __name__ == "__main__":
+    import netifaces
+    ifaces_without_lo = [x for x in netifaces.interfaces() if not x.startswith("lo")]


line too long (85 > 79 characters)

coveralls · 2018-01-03T23:52:29Z

Coverage decreased (-1.9%) to 65.824% when pulling 791768f on add_updater into a365e17 on master.

CODeRUS · 2018-01-04T00:20:31Z

miio/updater.py

+        self.server.timeout = 10
+
+        with open(file, 'rb') as f:
+            self.payload = f.read()


Should be memory inefficient

I think it doesn't matter here, as the file needs to be read at some point for sending it to the client. The code is however incomplete, there is currently no way to tell interface/IP to use for the url (e.g. when one has multiple network interfaces as I do). I will have to look more into it in a week when I'll be able to test it on the device.

The point i mean is you should read file by chunks and feed data to hash, reading hundreds megabytes to memory at once is a bad idea.

I understand what you mean, but at some the file has to be read (again) for sending over the wire to the device. I'll look into that though, thanks :-)

CODeRUS · 2018-01-06T21:17:52Z

btw, why own server? why handle_request so bad?

rytilahti · 2018-01-19T21:39:20Z

@CODeRUS I wanted to have it so that one can simply point it to any file (and not to expose the contents over HTTP), although I think changing to the source directory and launching the server there would be fine too.

Thanks for exploring the device in-depth goes to the dustcloud project, which also describes how to build own, custom firmwares.

houndci-bot · 2018-02-02T18:23:33Z

miio/updater.py

+    ifaces_without_lo = [x for x in netifaces.interfaces() if not x.startswith("lo")]
+    # print(ifaces_without_lo)
+    logging.basicConfig(level=logging.DEBUG)
+    upd = Updater("/tmp/test")


undefined name 'Updater'

… to fix the progress reporting

houndci-bot · 2018-02-17T12:36:48Z

miio/vacuumcontainers.py

        """True if install is in progress."""
-        return self.sid != 0 and self.progress < 100 and self.error == 0
+        return self.state == SoundInstallState.Downloading or \
+               self.state == SoundInstallState.Installing


continuation line over-indented for visual indent

houndci-bot · 2018-02-17T12:36:48Z

miio/vacuum_cli.py

+            try:
+                state = vac.update_state()
+                progress = vac.update_progress()
+            except: # we may not get our messages through during upload


at least two spaces before inline comment

houndci-bot · 2018-02-17T12:36:48Z

miio/vacuum_cli.py

+    if update_state == UpdateState.Downloading:
+        click.echo("Update progress: %s" % vac.update_progress())
+
+@cli.command()


expected 2 blank lines, found 1

houndci-bot · 2018-02-17T12:36:48Z

miio/vacuum_cli.py

    click.echo("Configuring wifi to SSID: %s" % ssid)
    click.echo(vac.configure_wifi(ssid, password, uid, timezone))

+@cli.command()


expected 2 blank lines, found 1

houndci-bot · 2018-02-17T12:36:48Z

miio/vacuumcontainers.py

        """True if install is in progress."""
-        return self.sid != 0 and self.progress < 100 and self.error == 0
+        return self.state == SoundInstallState.Downloading or \
+               self.state == SoundInstallState.Installing


continuation line over-indented for visual indent

houndci-bot · 2018-02-17T12:36:48Z

miio/vacuum_cli.py

+            try:
+                state = vac.update_state()
+                progress = vac.update_progress()
+            except: # we may not get our messages through during upload


at least two spaces before inline comment

houndci-bot · 2018-02-17T12:36:48Z

miio/vacuum_cli.py

+    if update_state == UpdateState.Downloading:
+        click.echo("Update progress: %s" % vac.update_progress())
+
+@cli.command()


expected 2 blank lines, found 1

houndci-bot · 2018-02-17T12:36:49Z

miio/vacuum_cli.py

    click.echo("Configuring wifi to SSID: %s" % ssid)
    click.echo(vac.configure_wifi(ssid, password, uid, timezone))

+@cli.command()


expected 2 blank lines, found 1

rytilahti · 2018-02-17T13:03:24Z

I think this is pretty much done and ready to be tested now. The code could be made cleaner, but that can be done later.

houndci-bot reviewed Jan 3, 2018

View reviewed changes

CODeRUS reviewed Jan 4, 2018

View reviewed changes

rytilahti mentioned this pull request Jan 15, 2018

Add preliminary support for managing sound files #154

Merged

rytilahti mentioned this pull request Jan 28, 2018

No token in miio2.db after version 5.0.29 of MiHome app... #185

Closed

rytilahti added 3 commits February 2, 2018 19:23

Add initial implementation for firmware updates

bc7252e

Thanks for exploring the device in-depth goes to the dustcloud project, which also describes how to build own, custom firmwares.

use getattr() and setattr() for fetch state

a8e5f5a

rename server and handler

b268cd3

rytilahti force-pushed the add_updater branch from 26fb61f to b268cd3 Compare February 2, 2018 18:23

houndci-bot reviewed Feb 2, 2018

View reviewed changes

rytilahti added 4 commits February 17, 2018 13:32

Add UpdateState enum, fix type in 'proc'

585b04b

find IP to use automatically, send content-length header for requests…

78d88d9

… to fix the progress reporting

Add better download & error reporting functionality for sound install

e582b21

install_sound and update_firmware are ready to be shipped after cleanups

40d65bf

houndci-bot reviewed Feb 17, 2018

View reviewed changes

Fix linting

791768f

rytilahti changed the title ~~WIP: Implement firmware update functionality~~ Implement firmware update functionality Feb 17, 2018

rytilahti mentioned this pull request Feb 18, 2018

Change sound files without re-flash the whole firmware dgiese/dustcloud#39

Closed

syssi merged commit fe193e5 into master Feb 19, 2018

rytilahti deleted the add_updater branch February 5, 2019 12:43

Uh oh!

Conversation

rytilahti commented Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CODeRUS commented Jan 6, 2018

Uh oh!

rytilahti commented Jan 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rytilahti commented Feb 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rytilahti commented Jan 3, 2018 •

edited

Loading

coveralls commented Jan 3, 2018 •

edited

Loading